[TYPO3-core] RFC: resolveBackPath in t3lib_iconworks

Michael Stucki michael at typo3.org
Fri Dec 1 13:37:22 CET 2006

Hi René,

>> I once tried (and failed) to resolve icon realted issues with skinning. I
>> am willing to believe your patch does mor good than any possible harm,
>> but I'd like to check the impat of this a little more than is possible
>> now.
>> So -1 for 4.0.3. It's too late.
> $absFile is just used to look if the file exist already
> if (@file_exists($absFile))
> end reading the file
> $im = t3lib_iconworks::imagecreatefrom($absFile);
> Nothing more. No hashes or something.

t3lib_iconworks::imagecreatefrom() will call t3lib_div::read_png_gif(), and
there the filename _is_ hashed!

But this also seems not to hurt. On the other side, I wonder _what_ is
actually not working with the existing code?

For me it's ok to change that, but consider that

a) typo3temp/ might blow up with duplicate files because the filename
   (containing the hash) has changed

b) the change seems not needed (so why risk a change?)

c) changing this in t3lib_iconworks is probably the wrong place (I would
prefer changing it at the beginning of t3lib_div::read_png_gif())

If you are sure that the change is needed, then go ahead.

- michael
Use a newsreader! Check out

More information about the TYPO3-team-core mailing list