[TYPO3-core] RFC: Bug 1655: Allow HTTPS in t3lib_div::substUrlsInPlainText()

Ingmar Schlecht ingmar at typo3.org
Wed Aug 23 16:54:27 CEST 2006


Sebastian Kurfuerst schrieb:
> Hi,
> 
> -1 stop!
> 
> I made a mistake.. The patch would replace every http or https url with
> http/https depending on the server setting.
> 
> So imagine you had an SSL server and a non-ssl URL, you would get an ssl
> url instead.

-1 here too, same reason.

The condition should not be:
	(t3lib_div::getIndpEnv('TYPO3_SSL') ? 'https://' : 'http://')

It should instead check whether the URL originally was an HTTPs URL. The
value of t3lib_div::getIndpEnv('TYPO3_SSL') should not be taken into
account at all, I'd say.

cheers
Ingmar



More information about the TYPO3-team-core mailing list