[TYPO3-core] RFC: Bug 1268: Respect config.notification_email_charset when sending emails

Michael Stucki michael at typo3.org
Wed Aug 23 10:13:20 CEST 2006

Hi Martin,

>> Solution:
>> Check if config.notification_email_charset is different from
>> config.renderCharset or if config.metaCharset differs from
>> config.renderCharset.
>> In both cases, use notifcation-/meta- charset as target and convert
>> recipient, subject, message and additional headers to the corresponding
>> charset (will later be encoded correctly by
>> t3lib_div::plainMailEncoded().
> Hm, somehow the code looks familiar :-)
> Much too familiar to make a +1 count from me.

I disagree. The code is still very different from the definition in
class.t3lib_formmail.php, this would require a lot of changes which is not
acceptable for a bugfix.

Please consider the cleanup [1] as a new feature, I'm even willing to work
on that but only _after_ this bug is fixed.

Attached is a new version which I propose to commit to Trunk only. It
contains a small set of changes which are a first start of a cleanup
(changing $enc to $encoding and setting the default encoding in the
function header).

For TYPO3_4-0 I still propose the V2 patch which I sent yesterday.

- michael

[1] Some ideas for such a cleanup:
    - Renaming "class.t3lib_htmlmail.php" to "class.t3lib_mail.php"
    - Moving all email related functions from "t3lib_div" into a new class
      "t3lib_mail_div", also inside "class.t3lib_mail.php"
Use a newsreader! Check out
-------------- next part --------------
A non-text attachment was scrubbed...
Name: bug_1268_notification_email_charset_v3.diff
Type: text/x-diff
Size: 7825 bytes
Desc: not available
Url : http://lists.netfielders.de/pipermail/typo3-team-core/attachments/20060823/75ad984c/attachment.bin 

More information about the TYPO3-team-core mailing list