[TYPO3-core] Gremlin #187: config.stat_apache_pagenames code [type] ends up empty (Clean the logfile writing)

[Bernhard Kraft]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Michael Stucki wrote:

> on line 1288 of class.tslib_fe.php:
> $pageName =tr_replace('[type]',$this->page['type'],$pageName);
> tslib_fe::getConfigArray() refers to $this->page['type'] which is empty

is good.


> 1) While working on this I also added a new feature: If the logfile does not
> exist yet, TYPO3 will try to automatically create it. Works fine here.

phps "touch" should be quite cross-os-compatible :)

> Because "echo" does only make sense if open_basedir is set, I first thought
> I keep this option. However, there is an is_file check which would never
> work anyway if open_basedir was used. So removing
> $TYPO3_CONF_VARS['logfile_write'] seems to be just fine!

It could work to don't make an isfile check when the "echo" method shall get used
this would enable it to have a logfile outside of openbase_dir.
I don't know if this is required ore more seen as a feature.
In my opinion it is ok to have just the fputs method.

So if nobody else complains about the missing "openbase_dir" feature you have
+1
from me


greets,
Bernhard
- --
- ----------------------------------------------------------------------
"Freiheit ist immer auch die Freiheit des Andersdenkenden"
Rosa Luxemburg, 1871 - 1919
- ----------------------------------------------------------------------
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFDYAmYIl4dkVkDMFkRApvsAKC8RceAOOiVubVqf4IQpKBnFIG57wCggqFL
HwbYLF+559Yt0NHwPB6v5ls=
=z/MZ
-----END PGP SIGNATURE-----