[TYPO3-core] create nice filenames
Martin.Kutschker at blackbox.net
Fri Nov 11 12:27:02 CET 2005
Christian Jul Jensen <julle at typo3.org> writes on
Fri, 11 Nov 2005 11:41:54 +0100 (MET):
> On Thursday 10 November 2005 14:21, Martin Kutschker wrote:
>> Modify the file name cleaning routine to do an ASCII-conversion with
>> t3lib_cs. Use the correct charset depending on context, but provide
>> an interface for overriding.
> looks fine, but I have a question: In the javadoc comment you've added
> a paramter, but not to the function parameter list...
Yeah, that was missing in the patch. I've corrected that (and moved the charset recognition after the object acquiring code).
> And another kind of silly thing, could you strip the .txt ending of
> your patch iles, so my mua can recognize it as a patch and open my
> diff viewer :)
Silly circumstances lead to that. I think this won't happen again.
More information about the TYPO3-team-core