[TYPO3-core] RFC: protect localconf.php from being lost

Martin Kutschker Martin.Kutschker at blackbox.net
Fri Dec 16 15:42:52 CET 2005


Karsten Dambekalns <karsten at typo3.org> writes on 
Fri, 16 Dec 2005 15:17:38 +0100 (MET):

> Hi.
> 
> On Friday 16 December 2005 11:08, Martin Kutschker wrote:
> 
> > Write the new config to a temp. file. Check if this has been
> > written properly and replace the old file.
> 
> -1



> Solution: change the temporary filename so it ends with .php


ok.


> Additionally I would delete the temporary file if it has been written
> but did not match the check wit strcmp or could not be renamed. This
> avoids a cluttered filesystem.


ok.


> As for the die() calls - what about just putting the error message
> into $this->messages[] and hope the admin will look carefully enough
> at the output? This way it could be called "graceful" error handling,
> somewhat at least.


I don't know where the message strings are used. When I changed the settings of an extension in the extension manager I did not see, the "updated" message. So the display of the message has to be implemented at least there. But again, I don't want to don this right now. I'm only fixing the dataloss bug (#1878).

Masi




More information about the TYPO3-team-core mailing list