[TYPO3-core] Bug #1574: Show visibility settings for contentelements in icon title

[Sebastian Kurfuerst]

Hi,

> Alternatively the new function could make more use of it's $table
> argument. So that all checks against $row['doktype'] etc are only done
> for "pages" records.
Good point! I did that.

> Anyway, the description of the new titleAttribForRecords() is wrong
> (talks about page records).
changed. If you have better suggestions for the description I'm happy to
hear them.


> Again, can you please make a "diff -wu" because I see that most stuff has
> just a tab less than it had in titleAttribForPages() before.
sorry, forgot that. it is attached.
> 
> Additionally, some comments/questions:
> - Why is "v#1." hardcoded?
that's the way it was. changed.
> - Please use "/.../" instead of "#...#" in preg_* functions. Stick to a
>   standard...
changed.
> - I notice that the function says it generates the "title" attribute but
>   sometimes it is assigned as the "alt" attribute. I know this is historical
>   and has nothing to do with your change, but maybe it would be nice to
>   normalize this now...
you are right, but how would you call the function instead? I didn't change that because
of missing ideas.

Thanks for your comments,

Greets, Sebastian
-- 
Sebastian Kurfuerst
http://garbage-group.de/kontakt.html
-------------- next part --------------
A non-text attachment was scrubbed...
Name: bug_1574_3.patch
Type: text/x-patch
Size: 9929 bytes
Desc: not available
Url : http://lists.netfielders.de/pipermail/typo3-team-core/attachments/20051211/c3e61162/attachment.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: bug_1574_3_w.patch
Type: text/x-patch
Size: 9741 bytes
Desc: not available
Url : http://lists.netfielders.de/pipermail/typo3-team-core/attachments/20051211/c3e61162/attachment-0001.bin