[TYPO3-team-core-v5] CLI Request Handler Test fails / Security Context Holder for CLI

[Andreas Förthner]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Hi Robert,

oh, that's a problem. I think it's a general question if the security context has to be initialized in the dispatcher or somewhere else. Of course the security context and especially the firewall (which needs an initialized context) have to be in place right after creating the request object or at least before any controller is called. Hm, I think these two things both happen in the dispatch() method of the dispatcher, right? Or do we have any possibility to setup the security framework somewhere else?
If not, I think we have two possibilities:

1. The dispatcher knows which security context holder is has to use depending on the request type.
2. The security context holder session uses the correct session functionality for any request type. So perhaps there would be a dummy session implementation for CLI mode, that does nothing. This would mean a new security context object is created for every CLI request. Or do we have some CLI session functionality? I didn't think about it, if something like that would be possible.

So what do you mean should be done?

Greets,

Andi

-----BEGIN PGP SIGNATURE-----
Version: PGP Universal 2.8.3
Charset: iso-8859-1

wpUDBQFIleiYVm6TtY1gxQoBCGomBACqHvdw5+IXmRtWdY6CSnRK9VI0dKytfkWH
r/0SzuHzwNlso1RLY0liT0YkLxOgYoRPTkwpFfk86kzRpFS1XtgraH/V5Kf6KBtx
ZvNdD31UWK1XZ9PuOn2f3tZMMbIup7DBg0zeWFpyg81By0Kb3ceP+cOutREVf61l
Tgev3pIHpw==
=wjs2
-----END PGP SIGNATURE-----