[TYPO3-commerce] RFC: #10433: Ressource leak in tx_commerce_product::get_Articles_by_AttributeArray

[Ingo Schmitt]

Hi Michael,

you patch will fail if there is no $result. So, there must be an if statement. Can you update you patch?

regards.

ingo

> This is an SVN patch request.
> 
> 
> 
> Type: Bugfix
> 
> 
> 
> Bugtracker references:
> 
> http://forge.typo3.org/issues/10433
> 
> 
> 
> Branches:
> 
> trunk
> 
> 
> 
> Problem:
> In the mentioned method tx_commerce_product::get_Articles_by_AttributeArray() t3lib_db::sql_free_result() is not called if the sql query returned no result. As far as I see the if-statement is completely useless, as calling t3lib_db::sql_fetch_assoc() is no problem even if the query returned no result.
> 
> Solution:
> Completely remove the if statement
> 
> Cheers,
> 
> Michael
> <com_10433.diff>_______________________________________________
> TYPO3-team-commerce mailing list
> TYPO3-team-commerce at lists.typo3.org
> http://lists.typo3.org/cgi-bin/mailman/listinfo/typo3-team-commerce


Mit freundlichen Gruessen
Ingo Schmitt

-- 
Marketing Factory Consulting GmbH  *   mailto:is at marketing-factory.de
Stephanienstrasse 36               *          Tel.: +49 211-361176-63
D-40211 Duesseldorf, Germany       *          Fax:  +49 211-361176-99
Amtsgericht Duesseldorf HRB 53971  * http://www.marketing-factory.de/

Geschaeftsfuehrer:    Peter Faisst   |   Katja Faisst
Karoline Steinfatt   |   Christoph Allefeld   |   Markus M. Kimmel