[TYPO3-commerce] RFC: #10433: Ressource leak in tx_commerce_product::get_Articles_by_AttributeArray

Michael Knabe t3 at aafhh.de
Mon Oct 25 16:38:33 CEST 2010


This is an SVN patch request.



Type: Bugfix



Bugtracker references:

http://forge.typo3.org/issues/10433



Branches:

trunk



Problem:
In the mentioned method 
tx_commerce_product::get_Articles_by_AttributeArray() 
t3lib_db::sql_free_result() is not called if the sql query returned no 
result. As far as I see the if-statement is completely useless, as 
calling t3lib_db::sql_fetch_assoc() is no problem even if the query 
returned no result.

Solution:
Completely remove the if statement

Cheers,

Michael
-------------- next part --------------
A non-text attachment was scrubbed...
Name: com_10433.diff
Type: text/x-patch
Size: 978 bytes
Desc: not available
URL: <http://lists.typo3.org/pipermail/typo3-team-commerce/attachments/20101025/f5dffa18/attachment.bin>


More information about the TYPO3-team-commerce mailing list