[TYPO3-mvc] Fluid performance patch backport to 4.5?!

[Bastian Waidelich]

Christian Kuhn wrote:

Hi Christian,

> I've now spent the better part of a day on back porting the thing to
> 4.5. In short: I think chances are low to get this merged in LTS.

What a pity. Thanks a lot for your work and the update though!

Just a few more thoughts in case anyone else dares to work on this one:

> - The patch is _big_ (the main patch adds 2,5k lines and removes 1,5k)
> [...]

That's right, the change is pretty huge: https://review.typo3.org/#/c/3838/

> - It has a nasty breaking change (this->argument() is not an object
> anymore in view helpers) that is hard to get rid off.

It should be possible to (re-)introduce a proxy object for compatibility 
reasons. It could implement ArrayAccess and forward methods like 
"hasArgument()" to the ViewHelper (possibly with a deprecation log entry).

> - The patch is highly intrusive: It changes interfaces, removes files,
> shifts lots of code around. Extensions that extend extbase / fluid core
> parts will likely break.

It shouldn't change the API (apart from the argument thing) and we 
haven't received feedback about breaking code.. But, sure, chances are..

> - It only works best together with other core patches, especially in the
> caching framework part, we also do not want to back port them.

Really? I thought that regarding the Caching Framework nothing really 
changed inside the core of Fluid!?


Thanks again for your work, I hope it wasn't too frustrating ;)

Best,
Bastian