[TYPO3-mvc] RFC #7937: Bug: missing isCached property for the request

Sebastian Kurfürst sebastian at typo3.org
Thu May 27 14:58:15 CEST 2010


Hey Xavier,

thanks for your RFC!

I think it's a good idea to do this.

I have some remarks; and I'll fix them and commit the code tomorrow
morning (so the remarks are a reminder to myself as well ;) ). It's all
cosmetic details.

* The RequestInterface should not have a method "setIsCached", as it is
  no part of the API the user should see.
* The method "setIsCached" should not have the @api annotation.
* The method "isCached" should have a comment stating that this API is
  not FLOW3 compatible.
* change the variable name in "setIsCached" from "$flag" to "$isCached"

So, as you see, it's all very cosmetic :-)

As promised, I'll commit it tomorrow morning.

Greets,
Sebastian


More information about the TYPO3-project-typo3v4mvc mailing list