[TYPO3-mvc] Refactoring of Typo3DbBackend::doLanguageAndWorkspaceOverlay

[Jochen Rau]

Hi Nikolas.

On 2010-07-13, Nikolas Hagelstein <lists at shr-now.de> wrote:
> i was just reading trough Typo3DbBackend::doLanguageAndWorkspaceOverlay 
> and came accross the following  i would like to hear your opinion about:
>
> The following should be moved out of the foreach loop.
> Partly to its own function:
>
> 1. pageSelectObject determination.
> 2. languageUid,workspaceUid and languageMode detection.
> 3. tableName determination.
> 4. overLaymode detection.
> 5. Check for languageField
> 6. overlayMode determination.
>
> Moving stuff out of the the loop probably would increase performance.

Yes, that makes sense. But IMO it is not a matter of performance but a matter of cklarity of code and an improved testability.

> If this makes sense to you i could provide a patch by friday afternoon.

Thanks in advance.

Jochen