[TYPO3-mvc] Question Code Review: Persistence_Query::statement()

[Xavier Perseguers]

Hi Sebastian,

> I just stumbled over the statement() method in Persistence_Query.
> 
> Shouldn't we rename this to setStatement()? On the other hand, it is not 
> a simple "Setter", but does some more things (which the user does not 
> need to know about).

The purpose of setter is to prevent direct access to a private/protected 
member variable. As such it seems OK to me that a setter may do more 
than simply storing the argument into the member variable...

-- 
Xavier Perseguers
MVC ExtJS Leader

http://forge.typo3.org/projects/show/extension-mvc_extjs