[TYPO3-caretaker] CheckPathService

Tobias Liebig mail_typo3 at etobi.de
Tue Mar 16 09:49:16 CET 2010


Hej Thomas,

Thomas Hempel wrote:
> Hi Felix,
>
>> I just made my first committ and built a CheckPathService. Somehow my
>> SVN client ate the "-F committ.msg", so here is, what I committed:
>>
>> * added CheckPathExists-Operation to test if a specified path exists
>> * added CheckPathTestService to test if one or more paths exists or do
>> not exist and are the right type (file/folder)
>>
>> Just have a look inside the test-section, I think it's pretty
>> self-explaining.
>>
>> If you have questions, feel free to email me. ;-)
>
> First of all, thanks for your work BUT...
>
> Please! Please! Please! DO NOT commit anything to the trunk just because
> you can!!!

Sorry, MY fault!

Christhopher and I had reviewed and tested felix code and I gave him my 
+1 to commit yesterday. i thought it will be ok, but your right, we 
should had file a issue on forge before.

I still think it's ok as
- the code IS reviewed (sure, you didn't know yet) and
- the idea for this test/operation IS born from a actual usecase here at 
networkteam.



>
> [...]
>
>
> I will not revert this. I think someone at networkteam should have a
> look at your changes because they mainly developed the
> caretaker_instance stuff.

√ check, done ;-)

regards
    Tobias




More information about the TYPO3-project-caretaker mailing list