[TYPO3-dev] SVN pre-commit hooks to avoid commiting php files with syntax errors

[Martin Kutschker]

Ries van Twisk schrieb:
> 
> On Sep 23, 2009, at 6:15 AM, Martin Kutschker wrote:
> 
>> Dmitry Dulepov schrieb:
>>> Hi!
>>>
>>> Ries van Twisk wrote:
>>>> Syntax check is the most un-useful feature for such a item,
>>>> all IDE's should already warn you (and they do...) for syntax errors.
>>>
>>> +1.
>>
>> I don't understand why both of you do not want the Core repository from
>> broken PHP. Yes, it shouldn't happen and the developer should (by
>> whatever means) make sure only valid code enters the
> 
> Martin, I think it's obvious that nobody want's PHP code with syntax
> errors in the core,
> but did that really happen in the past?
> 
> I think I was just trying to say it shouldn't be an area of
> concentration to improve on.

If we add up the time we needed to write all those messages, someone
could have implemented the hook already. It's just a brain deas hook
that calls "php -l" after all.

Masi