[TYPO3-dev] SVN pre-commit hooks to avoid commiting php files with syntax errors

[Ries van Twisk]

On Sep 23, 2009, at 6:15 AM, Martin Kutschker wrote:

> Dmitry Dulepov schrieb:
>> Hi!
>>
>> Ries van Twisk wrote:
>>> Syntax check is the most un-useful feature for such a item,
>>> all IDE's should already warn you (and they do...) for syntax  
>>> errors.
>>
>> +1.
>
> I don't understand why both of you do not want the Core repository  
> from
> broken PHP. Yes, it shouldn't happen and the developer should (by
> whatever means) make sure only valid code enters the

Martin, I think it's obvious that nobody want's PHP code with syntax  
errors in the core,
but did that really happen in the past?

I think I was just trying to say it shouldn't be an area of  
concentration to improve on.



>
>>> More useful would be for CGL check and run a unit test if
>>> appropriate for the code be checked in....
>>
>> +1000!!! Or even reformat the code according to CGL.
>
> Unit testing is a nice. But how is the test to be run before the  
> commit?
>
> As for auto-formatting: does this work safyely. I mean, is there no
> chance that the code is broken (or changed semantically) after a an
> auto-format? Anyway, if applied the syntax check must be done after  
> the
> auto-formatting.

I wouldn't auto re-format.... That's the task of the developer and  
it's toolset.

PS: Can I say this, may I say this... I am not part of core......

>
> Masi
> _______________________________________________
> TYPO3-dev mailing list
> TYPO3-dev at lists.netfielders.de
> http://lists.netfielders.de/cgi-bin/mailman/listinfo/typo3-dev


			regards, Ries van Twisk

-------------------------------------------------------------------------------------------------
tags: Freelance TYPO3 Glassfish JasperReports JasperETL Flex Blaze-DS  
WebORB PostgreSQL DB-Architect
email: ries at vantwisk.nl        web:   http://www.rvantwisk.nl/     
skype: callto://r.vantwisk
Phone: +1-810-476-4196    Cell: +593 9901 7694                   SIP:  
+1-747-690-5133