[TYPO3-dev] duplicated lines in TYPO3 detected by phpcpd

Martin Kutschker masi-no at spam-typo3.org
Fri Apr 24 08:57:04 CEST 2009


Andy Grunwald [wmdb] schrieb:
> 
> To describe all dublicate linesmake this post veeeery long, because i
> know that small maillinglist posts are very welcome :D
> So whats your opinion?
> Is this important or is this "task" bullshit?
> 
> My opinion is, that this is a very important point. 2907 duplicated
> lines are not few.

With or without the adodb parts? Anyway, while cleaning up is important
this is not on top of my least of the clean-up jobs in TYPO3. More
important IMHO is to replace die() with throw(), see to it that internal
methods (annotation @access private) become "protected" and that the
Core makes a good example and doesn't use stuff that has become deprecated.

However, small patches are always welcome. Please do yourself a favour
and do not try to get rid of all 2907 lines in one go.

Masi




More information about the TYPO3-dev mailing list