[TYPO3-dev] duplicated lines in TYPO3 detected by phpcpd

[Ries van Twisk]

On Apr 23, 2009, at 5:24 PM, Niels Pardon wrote:

> Hey Andy!
>
> Andy Grunwald [wmdb] schrieb:
>> Good Idea / Nice thought / ...
>> Some ideas for a nice solution in some parts ...
>> A little but usefull discussion about this topic ...
>>
>> I think, if we optimize TYPO3 in this fact and remove the duplicate
>> lines, there are > 2000 lines fewer to maintain.
>>
>> And to optimizie SourceCode is a very big but very usefull topic  
>> (words
>> for google: phpDepend, CruiseControll, PHPUnderControll, PHPUnit,
>> Continuous Integration, SVN Hooks, ...)
>
> Hm, well, yeah: good idea!
>
> Honestly I saw your post, read the first line and thought wow this guy
> put a lot of effort in writing this lines but then I was too lazy to
> read it till the end.
>
> I think that the message is as easy as this: There is a lot of  
> duplicate
> code in the core and a clean-up would be nice.
>
> So feel free to go ahead and submit a patch/patches to the core list.

You better talk to the core people first before you put a lot of  
efford in this.

Sometimes the duplicates do have a good reason, sometimes not
But I don't think that the core people are greedy in a massive overhaul.

May be the core people can tell you first what parts the would like to  
see cleaned up....

Ries
>
> Greets,
>
> Niels
>