[TYPO3-dev] Extension review

[Xavier Perseguers]

Hi Rik,

Had a quick overview to give you feedback.

> Since this is my first extension I would really appreciate it if some of 
> you could shortly look into the code. I'd like to make sure it is 
> written properly so others can use it safely. Any suggestions are welcome.


-------
((isset($this->conf['numberOfColumns']) && 
$this->conf['numberOfColumns'] > 0 ) ? $this->numberOfColumns = 
$this->conf['numberOfColumns'] :

             $this->numberOfColumns = 1);

Use a "if". The  "? :" ternary operator should not be used in place of a 
if, but only for (short) assignment like:

$foo = $someTest ? $value1 : $value2;

You use it as a if and put code that has side-effects in true/false 
parts, that is not "good" coding.

-------
$columnbreak = '';

camelCase?

-------
doc/wizard_form.dat
doc/wizard_form.html

Remove kickstarter files when you won't be able to go back to 
kickstarter anyway without destroying your work.


Regards

-- 
Xavier Perseguers
http://xavier.perseguers.ch/en

One contribution a day keeps the fork away