[TYPO3-dev] Extension review

[Rik Willems]

Hi Oliver,

Thanks for your comments. Will bring them along for new version.
I took irfaq as basis, that is why the style is php4.

Rik

Oliver Klee schreef:
> Hi,
> 
> Rik Willems schrieb:
>> Since this is my first extension I would really appreciate it if some of
>> you could shortly look into the code. I'd like to make sure it is
>> written properly so others can use it safely. Any suggestions are welcome.
> 
> Some first thoughts concerning code readability:
> 
> - Delete unused code instead of commenting it out (at least for code
> that's checked in to SVN or released in the TER).
> - Use proper PHP5-style access modifiers (public, private, protected)
> for functions and member variables (instead of "var").
> - Also add @var comments (including the type and a description) for the
> member variables.
> - Add documentation for all functions.
> - Don't use abbreviations like colNr, nrCols, faqObj, res ...
> - Use proper capitalization: css -> CSS, faq -> FAQ, ...
> 
> 
> Oliver