[Neos] FYI: Code Review Work today

Sebastian Kurfürst sebastian at typo3.org
Wed Aug 20 15:21:53 CEST 2014


Hey everybody,

as discussed in "Neos JavaScript Refactoring Work RFC", I just spent my
first half-day going through the Review Queue, more specifically Aske's
document. I thought it's best if I post a short list of what I have
done, together with how long it took -- this way it's as transparent as
possible for everybody; and in case you feel I am wasting time you can
let me know easily :-)

*REVIEWED / IMPROVED / MERGED*:
https://review.typo3.org/#/c/32250 [BUGFIX] Throw exception for missing
node in editable view helper
https://review.typo3.org/#/c/30968 [BUGFIX] Underscore is not allowed as
a TypoScript path value
https://review.typo3.org/#/c/30924 [BUGFIX] lastVisitedNode should be
reset when changing sites
https://review.typo3.org/#/c/32085 [TASK] Add unit test for JsonHelper
https://review.typo3.org/#/c/32239 [TASK] Code cleanup in node type
converter
https://review.typo3.org/#/c/32204 [FEATURE] “workspace:list” command
https://review.typo3.org/#/c/32200 [TASK] Allow all child nodes by
default if nothing is configured
https://review.typo3.org/#/c/31697 [FEATURE] Custom Node implementations
https://review.typo3.org/#/c/32236 [TASK] Remove link interception for
Aloha floating menu
https://review.typo3.org/#/c/30840 [FEATURE] Add new content element for
inserting records
https://review.typo3.org/#/c/32084 [TASK] Remove unneeded selenium
testing configuration

*CREATED*
https://review.typo3.org/#/c/32270/ allow to set related content nodes
--> this fixed a regression introduced by
https://review.typo3.org/#/c/31505/

*NOT MERGED YET, but spent time on it*
https://review.typo3.org/#/c/31148 [BUGFIX] Default value support for
internal node data properties


*TIME SPENT TODAY*
- 4:05 h on code reviews

Greets, Sebastian


More information about the Neos mailing list