[TYPO3-50-general] Willing to help Task #1 Create sniffs for PHP Code Sniffer
Malte Jansen
mail at maltejansen.de
Tue Dec 11 16:18:23 CET 2007
Hi Robert,
Robert Lemke schrieb:
> Hi Malte,
>
> Am 11.12.2007 um 14:43 schrieb Malte Jansen:
>>
>> In my mind there something like
>>
>> package required for system
>>
>> Dir:
>> CodingGuidelines
>> -Classes
>> --Sniff
>> ---Files (plurale or singulare?)
>> ---...
>> --Test
>> -ExternalCode
>> --PHPSniffer (copy of the current version without examples, so you only
>> have to copy these files, if there is sth. important)
>>
>
> okay, if you want to go for the TYPO3 Package structure already, then
> better
> put PHPSniffer in its own package:
>
> Packages/
> TYPO3CGL/
> Classes/
> T3_TYPO3CGL_CodingStandard.php
> Sniff/
> Classes/
> Commenting/
> Files/
> WhiteSpace/
> T3_TYPO3CGL_Sniff_WhiteSpace_ScopeClosingBrace.php
> Tests/
> Sniff/
> WhiteSpace/
> T3_TYPO3CGL_Sniff_WhiteSpace_ScopeClosingBraceTest.php
> Documentation/
> * we can place some documentation here ... *
>
> If we put the CodeSniffer into a TYPO3 package or not needs to be seen,
> but for the time being, just rely on the include path.
I think it is easier to handle later...
And what else should be the first with CodingGuidelines than the
Guidlines itsself? ;)
>
>> So it could be moved somewhere, but you don't have to change the basic
>> structure.
>>
>> Perhaps ExternalCode could also be a special dir of other OpenSource
>> Projects which are needed...
>
> We have the Resources/PHP/ dir for that in the TYPO3 packages. But for now
> just assume that Code Sniffer is in the include path.
>
>>>> ood idea. Maybe you find even more rules we can enforce.
>>>
>> Shall I add it to the Wiki?
Done.
Cheers,
Malte
More information about the TYPO3-project-5_0-general
mailing list