[TYPO3-50-general] Willing to help Task #1 Create sniffs for PHP Code Sniffer

[Malte Jansen]

Robert Lemke schrieb:
> Hi Malte,
> 
> Am 11.12.2007 um 13:37 schrieb Malte Jansen:
> 
>> Will the Coding standard be in a single Package?
> 
> I have no idea yet about where to put the sniff classes. For the time being
> I suggest that you just implement them as standalone classes which you put
> in a directory and that's it. As soon as we start with a TER3 or something
> similar, we might move them to that package.
> 
In my mind there something like

package required for system

Dir:
CodingGuidelines
-Classes
--Sniff
---Files (plurale or singulare?)
---...
--Test
-ExternalCode
--PHPSniffer (copy of the current version without examples, so you only
               have to copy these files, if there is sth. important)

So it could be moved somewhere, but you don't have to change the basic 
structure.

Perhaps ExternalCode could also be a special dir of other OpenSource 
Projects which are needed...

>> if yes: There should be a proper name for it like "CodingStandard" or
>> "CodingGuideline".
>>
>> else: Where is it located? You mentioned in the wiki, that there are two
>> rules are already implemented.
> 
> Tim wrote that comment. Best is if you agree on a place where you work on
> the files together. The easiest way for me would be if you could place
> it on your own webspace for development and testing. And when it's finished
> we install it at our 5.0 dev server.
I will mail Tim...

> 
>>> ### NEW RULE for Security ###
>> Perhaps it's is possible to disallow the $_GET, $_POST etc. So all
>> extension have to use functions of the framework it.
>>
>> So this could be are rule/createria for the TER3. You can only make a
>> workaround on local installation, but all packages in public go through
>> this check. Perhaps this check could also be done via a installation of
>> a package. This extension is disabled if something is found... (Only
>> this Rule)
>>
>> Somewhere it was an issue for security to disable this global-vars via
>> php-command. But I cannot remember, where it was...
> 
> Good idea. Maybe you find even more rules we can enforce.
> 
Shall I add it to the Wiki?

Cheers,
Malte