[TYPO3-dam-devel] RFC: #7676: Skin support

Sun Sep 21 02:40:12 CEST 2008

Noted. I'll see about fixing the issues, as well as the other points in 
the bug.

So should I leave the tabs? I was thinking the pull down menu 
corresponds more to the core, since it looks like the submodule 
selection menu. I can also move the tabs to position them better. I'll 
play around, and see what looks better. Do we have a deadline for 1.1?

Dan Osipov
Calkins Media
http://danosipov.com/blog/

Benjamin Mack wrote:
> Hey Dan,
> 
> I gave your patch a quick test run. Some issues still, until I'm fully 
> satisfied...
> 
> A. Testing
> 
> 1. I applied your patch, and first of all, the pages have still a slight 
> border around the <body> tag. See how we solved this in TYPO3 4.2 core 
> (check typo3/stylesheet.css around line 199-220 in the core package). 
> These lines should be added to all our pages. Maybe we can add  a 
> separate dam-t3skin.css in the extension directory so we don't need this 
> inline stuff anymore?
> 
> 2. The second red box in the screenshot shows that there is this nasty 
> background in this row. This comes from the oldskin, not the t3skin (I 
> hope I'm right here ;-). In any case, I propose to make this one 
> transparent / the same color as the background, only having the small 
> border on the bottom, makes it look really good.
> 
> 3. The third red box shows in my FF3 browser that the list with the 
> files uses too much space and therefore doesn't have the same margin as 
> on the left side.
> 
> 4. Screenshot 2+3: Check out the language selector in the DAM and in the 
> page module / TCEforms.
> 
> 
> B. Code Reviewing
> 
> 1. Use tabs instead of spaces to make it the same as in all the other 
> places.
> 
> +        $this->doc->setModuleTemplate('templates/alt_db_navframe.html');
> +        $this->doc->docType  = 'xhtml_trans';
> 
> 2. Don't comment out stuff, just remove it. This way it's easier to see 
> what you really removed in the files. Also everything is under source 
> control, so we won't delete anything that people might need :)
> 
> 3. As written in the other reply, let's use our own template files. Copy 
> them over to "dam/res/mod_templates/". In "dam/res/css/" we could put 
> the stylesheet file.
> 
> ========
> 
> Btw: Non-existence of tabs will be very strange for some people in the 
> first place (I like it :) makes it feel like it's closer to the core).
> 
> Cool stuff!
> 
> 
> ------------------------------------------------------------------------
> 
> 
> ------------------------------------------------------------------------
> 
> 
> ------------------------------------------------------------------------
> 