[TYPO3-dam-devel] RFC: #8598: Media > File: Icons are hidden by Fieldsize in IE 7.0

Benjamin Mack benni at typo3.org
Sat Jun 14 10:42:11 CEST 2008


Hey Dan,

nice! However I have one remark:

The code looks like this currently:
=========
$content = '
	<!-- CONTROL PANEL: tx_dam:'.$item['uid'].' -->
-	<div class="typo3-DBctrl">'.implode('', $actions).'</div>';
+	'.implode('', $actions).'';
}
=========

However, I suggest make it shorter, by just having

$content = implode('', $actions);

as we don't need the comment, also the line before "compile items into a 
DIV element, can go IMHO.

Can you make these small non-functional changes? Apart from that, it 
looks good. I will have a look at it again, once the other patch 
(styling) is improved as well again.

-- 
greetings,
benni.
-SDG-


More information about the TYPO3-team-dam mailing list