[TYPO3-dam-devel] RFC #8599: Replace dam extension of tx_rtehtmlarea_browse_links by implementation of interface t3lib_browselinkshook]

[Stanislas Rolland]

Hi Uschi,
> I tested your patch.
>   
Thanks for testing.
> Here is the report:
>
> I) Create Link
> 1) The media link does not show the class selector and does not respect 
> the settings from RTE.default.classesAnchor.default.file = myclass.
>   
This should be corrected with the attached revised patch. You can now 
set the configuration of the media link with

RTE.default.classesAnchor.default.media = myclass

You should also configure RTE.classesAnchor with type = media

> 2) I can set a title manually on creation of the link, but not the alt 
> attribute, which I might want to adapt to current contents needs as well.
>   
This is not a DAM issue, but related to the accessibility icons feature. 
The alt attribute is on the image element, not on the link itself. You 
cannot change the value of the alt attribute of the icon when editing 
the link. But you can change it if you update the icon as an image. This 
currently applies to all tabs with or without DAM.
> II) Modify link
> 1) If I want to modify the link the popup opens in TAB Page, not Media.
> 2)  If I then switch to the TAB Media, the Update button from normal 
> File TAB is missing. Thus I I cannot save modifications to the title 
> (alt and classes are not present here either) unless I select the same 
> file again.
>   
This should be corrected with the attached revised patch.
> III) Miscellaneous
> I am unsure whether this is your stuff or DAM stuff, but if I wanted to 
> change the standard title output [main mediatype], [title] [filesize], 
>   where would I do that?
>   
This title is not set by the RTE. In fact, the default title set by the 
RTE is the title configured for the class. But, after save, the title is 
overridden. I assume that this is done by the DAM-provided 
RTE-transformation for the media tag. Not sure whether this is 
configurable and where.

The revised patch re-introduces class.ux_tx_rtehtmlarea_browse_links.php 
because some changes are required on the RTE in order to correct the 
issues you reported.. These changes will be submitted to the core trunk 
for inclusion in TYPO3 4.3. The extended class will be used when 
operating with TYPO3 4.2, but will become deprecated and will not be 
used when operating with TYPO3 4.3.

I am attaching an additional patch applicable to TYPO3core in case you 
wish to test the patch with SVN TYPO3core trunk.
> Uschi (sending an afternoon coffee over the ocean)
>   
Thanks for the coffee!
Stan

>
>
>
>   
>> Hi all,
>>
>> This is an SVN patch request for the DAM project.
>>
>> Type: Bugfix/Cleanup
>>
>> Bugtracker references:
>> http://bugs.typo3.org/view.php?id=8599
>>
>> Branches:
>> trunk
>>
>> Problem:
>> Script compat/class.ux_tx_rtehtmlarea_browse_links.php replicates code
>> of the RTE which will make difficult the co-evolution of dam and
>> rtehtmlarea.
>>
>> Solution:
>> The attached patch replaces the class extension
>> compat/class.ux_tx_rtehtmlarea_browse_links.php by an implementation of
>> interface t3lib_browselinkshook:
>> compat/class.tx_dam_rtehtmlarea_browse_links.php. This minimizes the
>> code redundancy between the two extension.
>>
>> Notes:
>> 1. The patch creates a tab of type media instead of overriding the file
>> tab. As a side effect, the media tab is inserted as the last tab.
>> 2. This patch requires TYPO3 4.2.
>>
>> Kind regards,
>> Stanislas
>>
>>
>>     
> _______________________________________________
> Before posting to this list, please have a look to the posting rules
> on the following websites:
>
> http://typo3.org/teams/core/core-mailinglist-rules/
> http://typo3.org/development/bug-fixing/diff-and-patch/ 
> _______________________________________________
> TYPO3-team-dam mailing list
> TYPO3-team-dam at lists.netfielders.de
> http://lists.netfielders.de/cgi-bin/mailman/listinfo/typo3-team-dam
> ------------------------------------------------------------------------
>
>
> No virus found in this incoming message.
> Checked by AVG. 
> Version: 8.0.100 / Virus Database: 270.0.0/1485 - Release Date: 2008-06-05 10:07
>   

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.netfielders.de/pipermail/typo3-team-dam/attachments/20080610/2b4ffeb3/attachment-0001.htm 
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: dam_rtehtmlarea_bugfix_8599_V2.patch
Url: http://lists.netfielders.de/pipermail/typo3-team-dam/attachments/20080610/2b4ffeb3/attachment-0002.txt 
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: dam_rtehtmlarea_bugfix_8599_V2_core.patch
Url: http://lists.netfielders.de/pipermail/typo3-team-dam/attachments/20080610/2b4ffeb3/attachment-0003.txt