[TYPO3-dam-devel] RFC #8529: dam_ttcontent does not respect workspaces

[Francois Suter]

Hi Ingo,

I have finally found time to test your patch, unfortunately my tests are 
a bit incomplete, due to a faulty set up of mine (which I haven't really 
time to investigate right now).

About the previous trouble I had, I managed to apply your patch by 
indeed taking out and creating manually all the new files, then applying 
the rest of the patch.

Since it's quite a big patch, I felt the need to spell out what its 
different parts do, which is what is below here:

1) Part of the patch is just cleanup 
(pi_cssstyledcontent/class.tx_damttcontent_pi1.php)

2) class.ux_tx_cms_layout.php: you have moved to that XCLASS the code 
that you had previously put in tx_dam_db::referencesQuery() IIRC. That 
seems to make sense.

3) class.ux_wslib_gui.php and class.ux_tx_version_cm1.php: XCLASSes. 
Same code because of duplication in the core. Your patch adds a call to 
a hook called postProcessDiffView which provides a better diff view.

4) class.tx_damttcontent_workspacediffview.php: the actual class using 
the hook. In the hook you get the full record for the two versions of 
the DAM files which enables you to display an enhanced diff view.

5) ext_localconf.php: some cleanup and declarations of the XCLASSes and 
the hook.

6) ext_conf_template.txt: new configuration option for allowing the 
XCLASSing of the workspace module

What I got working properly:

1) when viewing the page, both live and workspace versions are correct.

2) the diff view is excellent.

As said above, I have some trouble with my setup. I currently don't have 
thumbnails showing in the BE, so I couldn't test whether the thumbnails 
were correct or not.

Now comes a question: you asked for other extensions that might have 
similar problems. Did you test your patch with those extensions? It 
seems to me that the 2 XCLASSes class.ux_wslib_gui.php and 
class.ux_tx_version_cm1.php, plus the class exploiting the hook could be 
moved to a separate extension from which all others could benefit. Is 
that indeed possible?

So I'm giving a +1, but would like to see if some of this stuff could be 
shared among the various extensions relying on the DAM. It's hard to 
imagine that all those extensions would have to duplicate all the code 
in your patch.

Cheers

-- 

Francois Suter
Cobweb Development Sarl - http://www.cobweb.ch