[TYPO3-core] RFC#15562: Bug/Nobrainer: PHP warning str_pad() in t3lib_div

[Markus Klein]

Hi Steffen,

thx for committing this patch.

@ CGL fixes:
I never intended to touch any other things than these quotes.
But I had a response
(http://lists.typo3.org/pipermail/typo3-team-core/2010-August/042554.html)
that requested me to fix some CGL issues.
I don't think it makes sense to fix CGL only for 2 lines, so I adjusted the
whole "paragraph".
But if Core Team says to keep the other lines, it's ok for me of course. np
:-)

@ Testcase:
I've to admit, that I didn't really "search" for this issue. I just had
these warnings in our server log, so I had a look.
When I saw that this was only such a "stupid" problem, I didn't further
investigate the settings leading to this code path.
v1 of the patch clearly showed this no-brainer. v2 was a bit messy due to
the CGL stuff.

So thanks again
Markus


> -----Original Message-----
> From: typo3-team-core-bounces at lists.typo3.org [mailto:typo3-team-core-
> bounces at lists.typo3.org] On Behalf Of Steffen Gebert
> Sent: Sunday, September 05, 2010 4:31 PM
> To: typo3-team-core at lists.typo3.org
> Subject: Re: [TYPO3-core] RFC#15562: Bug/Nobrainer: PHP warning str_pad()
> in t3lib_div
> 
> On 26.08.10 12:17, Markus Klein wrote:
> > Type: Bug, Nobrainer
> >
> > Bugtracker reference:
> > http://bugs.typo3.org/view.php?id=15562
> >
> > Branches:
> > Trunk, 4-4
> >
> > Problem:
> > A PHP warning is thrown as str_pad function is called with 4 paramters,
> where 4th parameter is given as string instead of constant.
> 
> Committed to
> - trunk rev. 8760
> - 4-4 rev. 8761
> 
> Thanks for your contribution, Markus!
> 
> Kind regards
> Steffen
> 
> --
> Steffen Gebert
> TYPO3 Core Team Member
> _______________________________________________
> Before posting to this list, please have a look to the posting rules on
the
> following websites:
> 
> http://typo3.org/teams/core/core-mailinglist-rules/
> http://typo3.org/development/bug-fixing/diff-and-patch/
> _______________________________________________
> TYPO3-team-core mailing list
> TYPO3-team-core at lists.typo3.org
> http://lists.typo3.org/cgi-bin/mailman/listinfo/typo3-team-core