[TYPO3-core] RFC #12066: Code cleanup: Add some constants

Oliver Klee typo3-german-02 at oliverklee.de
Sun Feb 21 16:14:27 CET 2010


Hi,

reminder ... I'd really love to see this checked in for 4.4 so extension
can use these constants.

Current review status on the big patch:
  +1 by reading by Niels
  +1 by reading and testing by Olly

I've updated the patch to the current trunk. For easier review (if
necessary), I've attached two patches:

- the complete patch
- the patch containing only the constants definition file and its inclusion

Things that are *not* part of this bug, but of possible follow-up bugs:

- CGL cleanup of the touched lines (because the biggest part of the
patch is search'n'replace with reading after that)
- Refactoring as suggested by Olly:
  I'd prefer to have these constants integrated to config_default.php
directly or to include/require the external file there. But that's more
cosmetical...



Oli
-- 
Certified TYPO3 Integrator | TYPO3 Security Team Member
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 12066-basic.diff
Type: text/x-patch
Size: 2443 bytes
Desc: not available
URL: <http://lists.typo3.org/pipermail/typo3-team-core/attachments/20100221/9872ccef/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 12066-v3.diff
Type: text/x-patch
Size: 202775 bytes
Desc: not available
URL: <http://lists.typo3.org/pipermail/typo3-team-core/attachments/20100221/9872ccef/attachment-0003.bin>


More information about the TYPO3-team-core mailing list