[TYPO3-core] RFC: #11260: Feature: Speed up xml2array by adding a two level cache

Oliver Hader oliver at typo3.org
Fri Jun 5 14:30:02 CEST 2009


Hi Masi,

Martin Kutschker schrieb:
> I think there is a problem with the identifier:
> 
> $identifier = md5($string . $NSprefix . $reportDocTag);
> 
> It's meant to be a boolean, but you PHP coders ;) So I suggest to
> normalize this parameter. Choose one of the suggestions:
> 
> md5($string . $NSprefix . ($reportDocTag ? '1' : '0');
> md5($string . $NSprefix . ($reportDocTag ? 'true' : 'false');
> md5($string . $NSprefix . ($reportDocTag == true));
> etc.

Agreed, it does not hurt to normalize this to 0/1...

olly
-- 
Oliver Hader
TYPO3 Release Manager 4.3


More information about the TYPO3-team-core mailing list