[TYPO3-core] RFC: #11260: Feature: Speed up xml2array by adding a two level cache

Martin Kutschker masi-no at spam-typo3.org
Fri Jun 5 13:41:51 CEST 2009


Fabrizio Branca schrieb:
> Hi,
> 
>> please make patches that apply against trunk root and add the bug id
>> to the
>> patch name.
> 
> (Ok, there _was_ some more I could have done wrong... :)
> 
> I've attached a new patch.

I think there is a problem with the identifier:

$identifier = md5($string . $NSprefix . $reportDocTag);

It's meant to be a boolean, but you PHP coders ;) So I suggest to
normalize this parameter. Choose one of the suggestions:

md5($string . $NSprefix . ($reportDocTag ? '1' : '0');
md5($string . $NSprefix . ($reportDocTag ? 'true' : 'false');
md5($string . $NSprefix . ($reportDocTag == true));
etc.

Masi


More information about the TYPO3-team-core mailing list