[TYPO3-v4] Welcome our new fellow reviewer

Steffen Gebert steffen.gebert at typo3.org
Thu Mar 24 15:43:19 CET 2011


> IMO it would be nice if there is sign of his presence. The question is
> in which form it will be ok four you?
>
> * start a buld
> * sucessfully build

For the moment, I prefer that it stays silent until it really finds a 
parse error.

As soon as we (you :)) have Unit Tests and/or Checkstyle running, I'm 
fine with always giving explicit +/-1 feedback.

Kind regards
Steffen

P.S. Code-review comments over ssh are not possible, yet. Thus I assume 
Checkstyle output could just be shown as review comment, not inline 
(which would be the perfect solution).
http://code.google.com/p/gerrit/issues/detail?id=602

-- 
Steffen Gebert
TYPO3 v4 Core Team Member

TYPO3 .... inspiring people to share!
Get involved: http://typo3.org


More information about the TYPO3-project-v4 mailing list