[TYPO3-commerce] Request for help: Clean up commerce

[Torben Hansen - Skyfillers]

Hi Cristian,

I did have a look at both of your patches and they look good to me. I did not work with fluid before, but after looking at your code I´m pretty sure I´ll do that in the future.

As soon as I´m accepted as team member, I will commit my first changes for the lib/ directory to trunk. Btw. - what´s with "lib/class.tx_commerce_item.php"? I can´t find any reference to that class so I think, it´s an old one which can be deleted.

Best regards,
Torben


> -----Ursprüngliche Nachricht-----
> Von: typo3-project-commerce-bounces at lists.typo3.org [mailto:typo3-project-
> commerce-bounces at lists.typo3.org] Im Auftrag von Christian Kuhn
> Gesendet: Sonntag, 15. Mai 2011 18:51
> An: TYPO3 commerce extension project
> Betreff: Re: [TYPO3-commerce] Request for help: Clean up commerce
> 
> Hey.
> 
> On 05/13/2011 01:44 AM, Christian Kuhn wrote:
> > 'Move to fluid' patch, now. You are invited to review!
> 
> Ok, there are now two pending patches: #26795 moves pi2 (basket) to fluid,
> #26827 moves pi6 (invoice) to fluid. Reviews are very much appreciated!
> 
> Plan for the next patches: I'd like to finish the move to fluid with the other pi's
> (I've already started the battle with pi4, but the remaining pi's are more
> complicated than pi2 and pi6). I've already dropped the idea to be completely
> backwards compatible, I see no other solution than breaking changes. The
> point is, that we end up with a solid code base this way ...
> 
> While creating the fluid patches I realized that the model / object layer is not
> really ideal, too (well, there exists one, which is already a big plus for
> commerce). Thus, after fluid, I'll start to work on this level. It would help a lot if
> we have a cleaned lib/ directory at this point!
> 
> Regards
> Christian
> _______________________________________________
> TYPO3-project-commerce mailing list
> TYPO3-project-commerce at lists.typo3.org
> http://lists.typo3.org/cgi-bin/mailman/listinfo/typo3-project-commerce