[TYPO3-commerce] paypal2commerce - Comment field

[Martin Holtz]

Hi,

as Rik said, the comment does not reach the commerce extension because
it gets redirected to paypal. So the comment is saved in a session.

As i am reading that, i think it should be stored in the commerce
session and not in an separat session...

But i would think your issue depends on $this->comment = ... because
that value seems to be used when writing to the database, but not when
using in the emails?

I would assume, that the email function uses some array with data
instead of $this->comment. Perhaps change that too?

My thoughts, without digging into the code:)

You could open an issue at forge -
http://forge.typo3.org/projects/extension-paypal2commerce/issues.

Dont forget to attach an patch if you have one:)

greetings,
martin

Am 09.07.2010 13:34, schrieb Franz Steinmetz:
> 
> I haven't tested the latest SVN but compared the code, it changes nothing 
> essentialy for this problem.
> 
> But I think the responsible code is this here:
> 
> function finishingFunction($config,$session, $basket, $pObj ) {
>         if(!is_object($this->pObj)) {
>             $this->pObj = $pObj;
>         }
>         // ok, we get the form
>         if ('' != t3lib_div::_POST('tx_commerce_pi3')) {
>             $GLOBALS['TSFE']->fe_user->setKey('ses', 'comment', 
> $pObj->piVars['comment']);
>             $GLOBALS["TSFE"]->storeSessionData();
>             $this->sendToPaypal( $basket->basket_sum_gross, 
> $pObj->conf['currency'] );
>         }
>         if (!$this->checkFromPaypal()) {
>             return false;            
>         } else {
>             // do not forget the comment;!!!
>             $this->comment = $GLOBALS['TSFE']->fe_user->getKey('ses', 
> 'comment');
>             $this->paymentRefId = 
> 'CORRELATIONID'.$this->resArray['CORRELATIONID'].'PAYERID'.$this->resArray['PAYERID'];
> 
>             return true;
>         }
> }
> 
> Perhaps someone can have a look on it, I can't say what is wrong here. It seems 
> to store the comment and retrieve it later.
> 
> Any idea?
> 
>  Franz
> 
> 
> franzlst at yahoo.de
> http://www.roboshow.de
> http://www.jsg-abi2008.de
> http://www.kalender.jsg-abi2008.de
> 
> 
> 
> ----- Ursprüngliche Mail ----
>> Von: Rik Willems <rik at actiview.nl>
>> An: typo3-project-commerce at lists.typo3.org
>> Gesendet: Donnerstag, den 8. Juli 2010, 11:41:01 Uhr
>> Betreff: Re: [TYPO3-commerce] paypal2commerce - Comment field
>>
>> Ah sorry, I missed that. If the order is saved the information is 
>> available.  In that case it is strange that only for paypal the comments 
>> do not appear  in the mail. Have you tested this with the svn version 
>> already?
>>
>> Greets, Rik
>>
>> Op 8-7-2010 11:10, Franz Steinmetz  schreef:
>>> Hi Rik,
>>>
>>> PayPal is external, yes. After  submitting, you are redirected to PayPal and
>>> having payed again  redirected to the success page of commerce. I don't know 
>> how
>>> exactly  this works. But as I have said, the comment isn't totally lost, it 
>> is
>>>  saved in the order table. It is just not shown in the mails.
>>>
>>>  Greets
>>>
>>>   Franz Steinmetz
>>>
>>>
>>> franzlst at yahoo.de
>>> http://www.roboshow.de
>>> http://www.jsg-abi2008.de
>>> http://www.kalender.jsg-abi2008.de
>>>
>>>
>>>
>>> -----  Ursprüngliche Mail ----
>>>> Von: Rik Willems<rik at actiview.nl>
>>>> An: typo3-project-commerce at lists.typo3.org
>>>>  Gesendet: Donnerstag, den 8. Juli 2010, 10:48:19 Uhr
>>>> Betreff: Re:  [TYPO3-commerce] paypal2commerce - Comment field
>>>>
>>>> Hi  Franz,
>>>>
>>>> What happens when you click the continue button  on the overview  page,
>>>> right before you are moved to the paypal  stuff? I assume the paypal
>>>> stuff is an external  service?
>>>>
>>>> Look at the form action on the listing   page of pi3. If it calls the
>>>> external service directly the comment  will  never reach commerce and is
>>>> therefore not  saved.
>>>>
>>>> Greets,   Rik
>>>>
>>>>
>>>> Op 7-7-2010 17:56, Franz Steinmetz  schreef:
>>>>>   Hi,
>>>>>
>>>>> I just  integrated paypal2commerce in a commerce shop.  Everything was  
>> very
>>>> easy, great praise to the  developers!
>>>>>
>>>>> I've  just got one problem: The  text of the comment box is removed when 
>> using
>>>> PayPal..  With  others payment methods (such as sofortüberweisung.de) there 
>> is no
>>>>  problem,  but with PayPal the comment text disappears in the mails. The  
>> comment
>>>> is saved  in the database, but isn't shown in the  mails, neither to the
>>>> costumer, nor to  the  admin.
>>>>>
>>>>> Has anyone an idea how to solve  this?
>>>>>
>>>>>   I use
>>>>> Typo3  4.2.6
>>>>> Commerce 0.9.8
>>>>> paypal2commerce   0.3.1
>>>>>
>>>>>  Thanks
>>>>>
>>>>>    Franz   Steinmetz
>>>>>
>>>>>
>>>>> franzlst at yahoo.de
>>>>> http://www.roboshow.de
>>>>> http://www.jsg-abi2008.de
>>>>> http://www.kalender.jsg-abi2008.de
>>>>>
>>>>>
>>>>>
>>>>  _______________________________________________
>>>>  TYPO3-project-commerce  mailing list
>>>> TYPO3-project-commerce at lists.typo3.org
>>>> http://lists.typo3.org/cgi-bin/mailman/listinfo/typo3-project-commerce
>>>>
>>>
>>>
>> _______________________________________________
>> TYPO3-project-commerce  mailing list
>> TYPO3-project-commerce at lists.typo3.org
>> http://lists.typo3.org/cgi-bin/mailman/listinfo/typo3-project-commerce
>>
> 
> 


-- 
Martin Holtz - elemente websolutions http://www.elemente-websolutions.ms

http://wiki.typo3.org/Ts45min - TypoScript in "45" minutes
http://wiki.typo3.org/De:ts45min - (auch in Deutsch)