[TYPO3-dev] CGL question

Franz Holzinger franz at ttproducts.de
Fri Feb 28 14:05:45 CET 2014


Hello Dmitry,

Le 26. 02. 14 12:50, Dmitry Dulepov a écrit :
>
> What is you opinion: does example #1 violate CGL or not?

in fact example #1 violates the CGL. Only the validity check of function 
parameters is allowed in the if clause before the return.

I would propose to allow any first return condition, independent of the 
kind of check done. There should be no constraint at all for it. This is 
because otherwise all the following PHP lines would be inside of a big 
IF clause. Those lines would be indented twice. This is a drawback. The 
code is more easily readable if the lines are nearer to the left position.

- Franz






More information about the TYPO3-dev mailing list