[TYPO3-dev] Questions about a Gerrit bugfix issue

[Xavier Perseguers]

Hi Loek,

> No friendly ghost this week? I'll just wait for a ghost friendly enough
> to dive into this.

Actually I'm the ghost :)

> The patch works, but now there is a critical question about it which I'd
> like to discuss. Should I discuss that using the review-comments in
> Gerrit? Or if I comment on the issue on forge, will the reviewers
> automatically receive a notice of that?

If you feel it might be too long to argue in Gerrit, then you better
should start a discussion in the Core list, just as we did before the
Gerrit-era.

> Anyway, it concerns
> http://forge.typo3.org/issues/32261
> https://review.typo3.org/#change,7022
> 
> There is feedback (with a -1) concerning the fact that the patch also
> changes or extends the functionality of the mkdir method and now I am
> wondering
> a. where to discuss this?

I'd say no need to discuss, Oliver Klee's point is just right, you are
changing the behavior of mkdir. I understand you don't want to duplicate
code but I guess it would be better then to make mkdir call mkdir_deep
for instance, but not the other way around.

> Meanwhile I found out that the bug was actually introduced by
> http://forge.typo3.org/issues/26240 which was included in TYPO3 4.6.
> Reverting that would solve the issue, we only loose the throwing of
> exceptions that was also introduced.

I don't see the point of reverting this one, just fix current code.

> Finally about the code: I actually prefer to merge the mkdir and
> mkdir_deep methods and deprecate mkdir_deep. That would minimize the
> amount of code, and mkdir would become more like an enhanced
> (typo3-)version of the php-mkdir.

That makes sense but we cannot change that for TYPO3 4.6 or below. So
you should consider fixing it "the way it is" in 4.6 (4.5?) and suggest
a deprecation in master (4.7), keeping in mind that it will have to be
supported until development of 4.9 starts anyway.

Regards

-- 
Xavier Perseguers
Release Manager TYPO3 4.6

TYPO3 .... inspiring people to share!
Get involved: http://typo3.org