[TYPO3-dev] Extremely slow HMENU in Typo3 4.2

[John Angel]

Got it!

typo3/sysext/cms/tslib/class.tslib_menu.php:1570

function menuTypoLink

If I put there this code (fetched from the 4.1.1), it drastically improves speed:
return $this->tmpl->linkData($page, $oTarget, $no_cache, $script, $overrideArray, $addParams, $typeOverride);

It has to do with this:
http://bugs.typo3.org/view.php?id=7839

The new code invites getRootline for every single page in the menu. SQL disaster.

There can be an option config.typolinkCheckRootlineDontCheckInMenu or we can try reducing the SQL load by caching getRootline and menu as I suggested earlier: http://bugs.typo3.org/view.php?id=5844 and http://bugs.typo3.org/view.php?id=5425

Regards,
John



> -----Original Message-----
> From: typo3-dev-bounces at lists.netfielders.de [mailto:typo3-dev-
> bounces at lists.netfielders.de] On Behalf Of Ingmar Schlecht
> Sent: Sunday, April 27, 2008 11:34 PM
> To: typo3-dev at lists.netfielders.de
> Subject: Re: [TYPO3-dev] Extremely slow HMENU in Typo3 4.2
> 
> John Angel schrieb:
> > I've done additional debugging and the HMENU problem is in both Live and Draft WS.
> >
> > I've compared v4.2 and v4.1.1 and the speed difference is huge.
> >
> > I can see that v4.2 invites getRootLine function for every single page in the menu which is
> ridiculous. v4.1.1 does not do that.
> 
> At which point exactly does it do that?
> 
> And could you try to spot in which changeset that call was introduced?
> 
> See
> http://code.typo3.org/v4/browser/TYPO3core/branches/TYPO3_4-2/typo3/sysext/cms/tslib
> for a nice view of the changesets.
> 
> cheers
> Ingmar
> 
> --
> Ingmar Schlecht
> TYPO3 Association Active Member
> _______________________________________________
> TYPO3-dev mailing list
> TYPO3-dev at lists.netfielders.de
> http://lists.netfielders.de/cgi-bin/mailman/listinfo/typo3-dev