[Typo3-dev] for the Gremlins team: new file button

[stefano cecere]

Martin Kutschker wrote:
> stefano cecere schrieb:

> I meant, closing the original form on top of the page (with </form>) is 
> ok. That's what you did.

i did add a <form></form>, that _also_ closes the upper form.
anyway there is still a </form> tag at the end of the page.. so the html of the whole page is not that bright.

if the pages have to be build in dynamic ways, using different functiosn and classes.. it should be avoided to open a <form> in the top header, and close in the the bottom footer
anyway the actual patch works.


MY QUESTION:
i see (in the html code of the backend) that actions are activated in very several ways..
<input> buttons without forms
<a href"">
<img> with javascript encoded url
<forms>
every method has it's way to encode the destination and returnUrl..

is there some direction about future developing and updating?

i personally use as much as i can <form></form>, and plain <a></a> if there are jsut few and simple GET parameters.


> What you should do is do the diff properly. The new lines should have a 
> + (add), your patch has them all with a - (remove). You must reverse the 
> order of the filenames when you do the diff.

thanks.. i did't find anywhere some tips about using the diff context..
i see you diffs also show the absolute paths of the files involved (mine shows just the filenames).. is it because you run diff from the root of the website?

stefano