[TYPO3-team-templavoila] RFC: #13526: selectbox for updating existing Data Structure / Template Object does wrong grouping if more sysfolders with the same name

[Steffen Kamper]

Hi,

This is an SVN patch request.

Type: bugfix

Bugtracker references:
http://bugs.typo3.org/view.php?id=13526

Branches:
trunk, 1_4

The selectbox for selecting an existing Data Structure / Template Object 
for update shows some TOs belonging to the wrong sysfolder(pid), if 
there are more than one sysfolder with the same title.

SVN-rev:29964 line 946-947

if ($sFolder != $this->storageFolders[$row['pid']]) {
     $sFolder = $this->storageFolders[$row['pid']];

the code only stores the title of the page and not the pid

later in line 851 the pid is appended to the sysfoldername for building 
the optgroup

$opt[] = '<optgroup label="' . htmlspecialchars($sFolder . ' (PID: ' . 
$row['pid'] . ')') . '">';

but in the next loop only the name is checked and not the pid

Solution:
order by pid and use the pid as unique identifier for storageFolder.

vg Steffen
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 13526_v2.diff
URL: <http://lists.typo3.org/pipermail/typo3-team-templavoila/attachments/20100213/d312848f/attachment.txt>