[TYPO3-team-templavoila] RFC: #12536: Pagemodule is broken on 4.3

[Francois Suter]

Hi,

> The recordlist changed with #11764 and needs an instance of 
> t3lib_teansl8tools
> 
> Without it produce a fatal error:
> Fatal error: Call to a member function getSystemLanguages() on a 
> non-object in C:\xampp2\htdocs\home\t3lib\class.t3lib_recordlist.php on 
> line 382

I'm glad you looked up this issue. I stumbled on it a while ago, but 
never looked into it. Your patch works, but after reviewing it I think 
it's the wrong cure for the symptom. It's a Core issue actually.

If you work up the inheritance tree of all these record list classes, 
the original class is t3lib_recordList. This is where the translateTools 
member variable is declared, and used too. This is where it should be 
instantiated, in the constructor. Instead of that, it is instantiated 
outside of the class in SC_db_list which is wrong.

The attached patch moves the instantiation into t3lib_recordList and 
removes it from typo3/db_list.php.

What do you think?

-- 

Francois Suter
Cobweb Development Sarl - http://www.cobweb.ch
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 12536-alt.diff
URL: <http://lists.typo3.org/pipermail/typo3-team-templavoila/attachments/20091113/329bb77e/attachment.asc>