[TYPO3-dam-devel] RFC #8599: Replace dam extension of tx_rtehtmlarea_browse_links by implementation of interface t3lib_browselinkshook]

[Stanislas Rolland]

Hi Uschi,

I am attaching a revised combined patch for issues #8599 and #8673.

TYPO3core should be updated to revision 3829+.

There is still a JS error when inserting an image complaining that 
clickmenu is not defined. This issue is reported and a patch is provided 
in bugtracker issue http://bugs.typo3.org/view.php?id=8316

With kind regards,
Stan



Uschi Renziehausen a écrit :
> Hello Stan :-)
>
> I did as I was told: Core updated to revision 3827, reverted the last 
> dam changes, applied the new combined patch, cleared the cache, deleted 
> the js files, and now this is what i get both when i try to insert a 
> link OR an image:
>
> Fatal error: Cannot redeclare class ux_tx_rtehtmlarea_select_image in 
> J:\web\typotester.de\htdocs-neu\typo3conf\ext\dam\compat\class.ux_tx_rtehtmlarea_select_image.php 
> on line 1310.
>
> Sniff, a Uschi bidding a good night
>
>
> Stanislas Rolland wrote:
>   
>> Hi Uschi,
>>     
>>> Issue 1)
>>> When I insert a media link and assign a class for which the target 
>>> attribute has been predefined [1] the target attribute does not get 
>>> inserted with the link. This one is for Stan, I suppose.
>>>   
>>>       
>> I committed patches to TYPO3core trunk and branch TYPO3_4-2 to fix this 
>> issue that already exists when DAM is not used and also when the DAM 
>> 1.0.13 browser is used. You should update your TYPO3 core to SVN 
>> revision 3827.
>>
>> I also committed patches so that 
>> dam/compat/class.ux_tx_rtehtmlarea_browse_links.php should be deleted.
>>
>>     
>
>
>   
>> Now you will need a new patch for DAM. I am attaching a combined patch 
>> for issues #8599 and #8673 in order to simplify their application.
>>
>> Regards,
>> Stan
>>
>>
>>     
>>> ______________________________________
>>>
>>> [1] Footnote for those who do not know: Since rtehtmlarea 1.7.4 you 
>>> can set a target attribute for those classes that are meant to open up 
>>> in a new window. Thus you can safely disable the target-selector and 
>>> save your authors one click they might forget.
>>>
>>>    // class with predefined target
>>> RTE.classesAnchor.internalLinkInNewWindow {
>>>     class = internal-link-new-window
>>>     type = page
>>>     titleText = 
>>> LLL:EXT:acadrteconf/locallang_rte.xml:title-internal-link-new-window
>>>     target = _blank
>>> }
>>>
>>>    // disable target selector in link dialogue
>>> buttons.link.targetSelector.disabled = 1
>>> _______________________________________________
>>> Before posting to this list, please have a look to the posting rules
>>> on the following websites:
>>>
>>> http://typo3.org/teams/core/core-mailinglist-rules/
>>> http://typo3.org/development/bug-fixing/diff-and-patch/ 
>>> _______________________________________________
>>> TYPO3-team-dam mailing list
>>> TYPO3-team-dam at lists.netfielders.de
>>> http://lists.netfielders.de/cgi-bin/mailman/listinfo/typo3-team-dam
>>> ------------------------------------------------------------------------
>>>
>>>
>>> No virus found in this incoming message.
>>> Checked by AVG. Version: 8.0.100 / Virus Database: 270.3.0/1502 - 
>>> Release Date: 2008-06-13 19:25
>>>   
>>>       
>>     
> _______________________________________________
> Before posting to this list, please have a look to the posting rules
> on the following websites:
>
> http://typo3.org/teams/core/core-mailinglist-rules/
> http://typo3.org/development/bug-fixing/diff-and-patch/ 
> _______________________________________________
> TYPO3-team-dam mailing list
> TYPO3-team-dam at lists.netfielders.de
> http://lists.netfielders.de/cgi-bin/mailman/listinfo/typo3-team-dam
> ------------------------------------------------------------------------
>
>
> No virus found in this incoming message.
> Checked by AVG. 
> Version: 8.0.100 / Virus Database: 270.3.0/1505 - Release Date: 2008-06-16 07:20
>   

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.netfielders.de/pipermail/typo3-team-dam/attachments/20080617/d7a9c2b5/attachment-0001.htm 
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: dam_rtehtmlarea_bugfix_8599_and_8673_V2.patch
Url: http://lists.netfielders.de/pipermail/typo3-team-dam/attachments/20080617/d7a9c2b5/attachment-0001.txt