[TYPO3-dam-devel] RFC #8673: Incorrect handling of images in the RTE with TYPO3 4.2 and current trunk DAM

[Uschi Renziehausen]

Hi Stan,

I tried to patch dam_rtehtmlarea_bugfix_8673.patch, but somehow I cannot 
get it right.

First difficulty comes in when you try to apply that patch after having 
applied the media patch (dam_rtehtmlarea_bugfix_8599_V3.patch). The hunk 
for ext_localconf.php was not accepted so I fixed that manually by 
adding this line:
$TYPO3_CONF_VARS[TYPO3_MODE]['XCLASS']['ext/rtehtmlarea/mod4/class.tx_rtehtmlarea_select_image.php'] 
= PATH_txdam.'compat/class.ux_tx_rtehtmlarea_select_image.php';

If that was the correct way, my report is this:

I cannot insert an image, because as soon as I click on an image in the 
media browser, the popup window becomes white and no image is inserted.

I then reverted all changes to DAM so that the media patch is not in and 
applied the image patch again, but that ends up in a fatal error:

Fatal error: Cannot redeclare class ux_tx_rtehtmlarea_select_image in 
J:\web\typotester.de\htdocs-neu\typo3conf\ext\dam\compat\class.ux_tx_rtehtmlarea_select_image.php 
on line 1310

Uschi (being a bit helpless ...)


Stanislas Rolland wrote:
> Hi DAM team,
> 
> This is an SVN patch request for the DAM project.
> 
> Type: Bugfix/Cleanup
> 
> Bugtracker references:
> http://bugs.typo3.org/view.php?id=8673
> 
> Branches:
> trunk
> 
> Problem:
> Insert/modify image using the DAM media browser does not support the 
> features introduced in htmlArea RTE in TYPO3 4.2.
> 
> Solution:
> The attached patch fixes the issue. It introduces a new class: 
> dam/compat/ux_tx_rtehtmlarea_select_image which extends the 
> corresponding class of rtehtmlarea. This extended class will be used 
> with TYPO3 4.2. It will become deprecated and will be ignored when 
> operating with TYPO3core trunk.
> 
> The patch also adds a txdam attribute to the img tag with value set to 
> the DAM uid of the media. However, processing of the attribute by either 
> RTE-transformation or FE rendering for updating any changes in the image 
> path is not included in this patch.
> 
> The htmlArea RTE EM checkbox for DAM should be unchecked. The DAM EM 
> checkbox for htmlARea RTE should be checked.
> 
> The attached companion patch applies to TYPO3core trunk (for inclusion 
> in TYPO3 4.3) and restructures class tx_rtehtmlarea_select_image so as 
> to encapsulate and hide from 
> dam/compat/class.tx_dam_rtehtmlarea_browse_media.php most details 
> internal to the RTE. 
> rtehtmlarea/mod4/class.tx_rtehtmlarea_dam_browse_media.php will be 
> deleted from TYPO3core trunk. The htmlArea RTE EM checkbox for DAM will 
> also be deleted from TYPO3core trunk.(these last changes are not 
> included in attached patch).
> 
> Note:
> With the hope of avoiding confusion, changes to TYPO3core trunk will be 
> committed only after the release of the next version of DAM (requiring 
> TYPO3 4.2).
> 
> Kind regards,
> Stanislas
>