[TYPO3-dam-devel] RFC: #8598: Media > File: Icons are hidden by Fieldsize in IE 7.0
Dan Osipov
dosipov at phillyburbs.com
Thu Aug 7 16:03:14 CEST 2008
Correction: this patch applies to 1.0.14 as well as the trunk branches.
Enough people have confirmed that the patch works on the bugtracker (see
the three duplicate bugs filed for this issue). Can it be commited, or
are we still waiting for the last approval here?
Dan Osipov
Calkins Media
http://danosipov.com/blog/
Dan Osipov wrote:
> I agree, I thought to provide a quick fix for the problem. Attached is
> the more complete solution, with accordance to the comments.
>
> Dan Osipov
> Calkins Media
> http://phillyburbs.com/
>
> Benjamin Mack wrote:
>> Hey Dan,
>>
>> nice! However I have one remark:
>>
>> The code looks like this currently:
>> =========
>> $content = '
>> <!-- CONTROL PANEL: tx_dam:'.$item['uid'].' -->
>> - <div class="typo3-DBctrl">'.implode('', $actions).'</div>';
>> + '.implode('', $actions).'';
>> }
>> =========
>>
>> However, I suggest make it shorter, by just having
>>
>> $content = implode('', $actions);
>>
>> as we don't need the comment, also the line before "compile items into
>> a DIV element, can go IMHO.
>>
>> Can you make these small non-functional changes? Apart from that, it
>> looks good. I will have a look at it again, once the other patch
>> (styling) is improved as well again.
>>
More information about the TYPO3-team-dam
mailing list