[TYPO3-core] Error in git hook (commit-msg) file
Simon Schaufelberger (Schaufi)
simonschaufi at guugelmail.de
Thu Feb 19 13:59:02 CET 2015
ok, but doesn't it make sense to use some of those validations also for
extensions/packages? Things like Fixes/Resolves or Releases also make
sense for other things too, or?
Am 19.02.2015 um 03:22 schrieb Markus Klein:
> Hi Simon,
> thanks for digging into this code, but I've to tell you, that this hook is used for Core ONLY.
> Therefore it only considers the version numbers we use in the Core. It might not be appropriate for your projects.
> All other projects, to my knowledge, currently still use the plain/original hook provided by Gerrit.
> You might wanna use http://www.wwwision.de/githelper/ , which usually gives you the right commit hook with the chosen project.
> Kind regards
> Markus Klein
> TYPO3 CMS Active Contributors Team Member
>> -----Original Message-----
>> From: typo3-team-core-bounces at lists.typo3.org [mailto:typo3-team-core-
>> bounces at lists.typo3.org] On Behalf Of Simon Schaufelberger (Schaufi)
>> Sent: Thursday, February 19, 2015 12:48 AM
>> To: typo3-team-core at lists.typo3.org
>> Subject: [TYPO3-core] Error in git hook (commit-msg) file
>> this line has a bug:
>> if ! egrep -q '^Releases: (master|[0-9]\.[0-9])(, *(master|[0-9]\.[0-9]))*$'
>> "$MSG"; then
>> it does not consider Releases like 1.10 or 1.1.1
>> this is my proposed changed line:
>> if ! egrep -q '^Releases: (master|[0-9]+\.[0-9]+(\.[0-9]+))(,
>> *(master|[0-9]+\.[0-9]+(\.[0-9]+)))*$' "$MSG"; then
>> can somebody please change that who has write access to this file? Thanx!
>> Regards, Schaufi
>> Before posting to this list, please have a look to the posting rules
>> on the following websites:
>> TYPO3-team-core mailing list
>> TYPO3-team-core at lists.typo3.org
More information about the TYPO3-team-core