[TYPO3-core] Reverting patches
eb at cron.eu
Thu Feb 27 17:12:16 CET 2014
Markus Klein schrieb am 27.02.2014 14:50:
> Thanks for your feedback. I updated the wiki page to incorporate your ideas.
> Please check again. Thx.
> Kind regards
> Markus Klein
> TYPO3 CMS Active Contributors Team Member
>> Markus Klein schrieb am 26.02.2014 22:26:
>>> Since I stumbled over quite some reverted patches in the last days and it
>> was not always to figure out what relationship was between the revert, the
>> original patch, the tickets involved etc.
>>> I decided to create a small guideline on how this process should happen
>> and what information a revert should contain.
>>> I took the freedom to add this directly to these pages:
>>> I looking forward to your comments and additions.
>>> Thanks you.
>> Good idea Markus, and nice text!
>> I would also like - as we decided some time ago - that the revert commit
>> message should not only contain the subject, reverted commit hash and the
>> issue tags, but also a short explanation why it was reverted. This makes it
>> easier to understand what's going on when just reading over the commit
>> We also had some reference reverts which were then also brought as a
>> thread to discussion in this list, but I like and prefer your idea of having a
>> dedicated issue on forge for it, then discussions about it could go there for
>> whoever is interested.
>> In order to make the commit appear in the issue, the "revert issue" has to be
>> created before hand. In your list of "todos" when reverting patches, you
>> might want to mention this as the first step before hitting the revert button
>> in Gerrit:
>> * Create an issue on forge explaining the problems with the original commit
>> and the reason for the revert
>> So +1 on my side on that!
>> Ernesto Baschny
>> TYPO3 CMS Core Developer
>> Release Manager TYPO3 4.5 & 6.2 LTS
>> TYPO3 .... inspiring people to share!
>> Get involved: typo3.org
>> Before posting to this list, please have a look to the posting rules on the
>> following websites:
>> TYPO3-team-core mailing list
>> TYPO3-team-core at lists.typo3.org
More information about the TYPO3-team-core