[TYPO3-core] JumpUrl restructuring

Alexander Stehlik alexander.stehlik at gmail.com
Mon Oct 14 17:05:20 CEST 2013


Hi everybody,

the issue was now split because it relates to the getPublicUrl() method 
of FAL:

http://forge.typo3.org/issues/52806

The JumpURL patch is now depending on the FAL patch:

http://forge.typo3.org/issues/52156

Would be great if this will make it before tomorrow's feature freeze :)

Cheers,
Alex


Am 13.10.2013 15:51, schrieb Alexander Stehlik:
> Hi Guys,
>
> that is great news :)
>
> I uploaded a new patchset to Gerrit:
>
> https://review.typo3.org/#/c/23940/
>
> There is one question still open:
>
> Should the getPublicUrl() method of a file / folder not URL encode
> special characters in the file path and filename? As far as I can see
> this should be done in the LocalDriver class. I mean, this method is
> supposed to return a valid URL, right?
>
> Maybe the snippet from the jump URL links can be reused to do that since
> it seems to work quite good:
>
> str_replace('%2F', '/', rawurlencode($fileUrl));
>
> Then I could get rid of the URL encoding in the typolink() method which
> I do not really like the way it is currently implemented (see also
> inline comments in the patch request).
>
> Cheers,
> Alex
>
> Am 11.10.2013 16:21, schrieb Helmut Hummel:
>> Hi Alex,
>>
>> On 10.10.13 11:25, Oliver Hader wrote:
>>
>>> this topic is on our agenda for further discussion at the current TYPO3
>>> CMS code sprint in Hannover [1]..
>>
>> We agreed that such a change is a good enough refactoring step which can
>> be built upon.
>>
>> So if the change itself works and does not introduce further issues, it
>> can be accepted.
>>
>> Please note that it should be ready until feature freeze next Tuesday if
>> it is targeted for 6.2
>>
>> Kind regards,
>> Helmut
>>
>



More information about the TYPO3-team-core mailing list