[TYPO3-core] RFC: CGL changes (closing php tag, multiline string concate)

Dmitry Dulepov dmitry.dulepov at gmail.com
Wed May 22 14:39:58 CEST 2013


Hi!

Alexander Opitz wrote:
> 1) Remove closing PHP Tag and add one empty line
>
> http://docs.typo3.org/typo3cms/CodingGuidelinesReference/PhpFileFormatting/GeneralRequirementsForPhpFiles/Index.html#php-tags
>
>
> At the moment we have a closing php tag and no new line after that tag
> course of output compression and AJAX errors (so is it documented). But
> this makes the difftools sometimes unhappy "There is no newline at the
> end of the file".
>
> Thats why I'd like to remove the closing php tag "?>" and add a new
> line. This solves both problems and is PSR2 standard.

When I edit files in vim, the empty lines at the end are removed 
automatically. I have that in several environments. I expect that requiring 
empty lines will cause issues for multiple people. So I am -1 to that.

-- 
Dmitry Dulepov


More information about the TYPO3-team-core mailing list