[TYPO3-core] State of TYPO3 OpenID

Christian Weiske cweiske at cweiske.de
Wed Jul 10 21:31:29 CEST 2013

Hello Dmitry,

> > And yes, I move the code up in the file - this has the effect that
> > the checks are done later, after the OpenID login process happened.
> The check you moved is the check that the login is in progress. If
> not, it returns. Basically you did an early return, thatš all. I do
> not see how this changes the functionality. 

Have a look at line 185 and following:
> // Here if user just started authentication
> $userRecord = $this->getUserRecord($this->openIDIdentifier);

This is the original. It fetches the user record from the database
instantly when the user gave the identifier. This fails in case of
generic endpoint identifiers.

I change this code to try to parse the url, and when this succeeds and
a protocol and host is set, the OpenID request is sent.
That way the OpenID login process is started before fetching the user

Christian Weiske

More information about the TYPO3-team-core mailing list