[TYPO3-core] Review system woes

Philipp Gampe philipp.gampe at typo3.org
Thu Feb 7 18:38:44 CET 2013


Hi Alexander,

Alexander Opitz wrote:

> Beside of this, I don't know why I
> should write a test scenario inside a commit message when all should be
> described in the bug report, how to reproduce.

You should not write a test scenario in the commit message. You can find 
hinds on the internet on how to write a good commit message.

Basically, describe the problem in one or two sentences, then describe how 
you fix it.
The purpose of the commit message is that you can are able to figure out why 
a specific chunk of code has change.
All information not relevant for this should go to the issue tracker or 
change review system.
That is why the links to the issue tracker on change review are also part of 
the commit message.

Once a change is in the review system, make sure to always add a comment 
there if you add information to the issue system. Otherwise it might not get 
noticed. Of course, it would be best if a change in the issue system would 
trigger a comment automatically, but that needs someone to get his hands 
dirty.

Best regards
-- 
Philipp Gampe – PGP-Key 0AD96065 – TYPO3 UG Bonn/Köln
Documentation – linkvalidator
TYPO3 .... inspiring people to share!



More information about the TYPO3-team-core mailing list